Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Second level cache with Version, DDC #7067 #7069

Merged
merged 2 commits into from
Feb 17, 2018

Conversation

wtorsi
Copy link

@wtorsi wtorsi commented Feb 16, 2018

No description provided.

@Ocramius
Copy link
Member

@wtorsi thanks! Linking #7067

@lcobucci lcobucci force-pushed the master branch 2 times, most recently from dfa263a to 9480093 Compare February 17, 2018 17:01
@lcobucci lcobucci self-assigned this Feb 17, 2018
@lcobucci lcobucci added this to the 2.6.1 milestone Feb 17, 2018
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtorsi nice job!

I've applied some small fixes on the patch and it LGTM 👍

@lcobucci
Copy link
Member

I'll just wait for #7076 to fix the build and rebase this branch to ensure that everything still works.

‘Andrey Lukin’ added 2 commits February 17, 2018 18:38
As explained in doctrine#7067, fields with `@ORM\Version` annotation were not
being added to L2C cached data.
@lcobucci
Copy link
Member

@wtorsi 🚢 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants